Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loongarch build fails for clang-14 #1941

Closed
nickdesaulniers opened this issue Oct 5, 2023 · 4 comments
Closed

loongarch build fails for clang-14 #1941

nickdesaulniers opened this issue Oct 5, 2023 · 4 comments
Labels
[ARCH] loongarch This bug impacts ARCH=loongarch [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 6.8 This bug was fixed in Linux 6.8

Comments

@nickdesaulniers
Copy link
Member

@TanzHasan mentioned hitting errors related to -msoft-float when trying to build ARCH=loongarch. I noticed he was using clang-14. I suspect we need to update the version checking script to limit loongarch builds with clang to an explicit newer version.
@nickdesaulniers nickdesaulniers added good first issue Good for newcomers [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] loongarch This bug impacts ARCH=loongarch labels Oct 5, 2023
@nathanchance
Copy link
Member

This has come up before, Huacai was not a fan of adding a version check prior to defconfig working it seems: https://lore.kernel.org/CAAhV-H7MeiZpSh28j2TDSwS1ae0L+rGMA7hi+MV2Z3uCiguLkw@mail.gmail.com/

@nathanchance nathanchance mentioned this issue Jan 7, 2024
Closed
@nickdesaulniers
Copy link
Member Author

submitted: https://lore.kernel.org/llvm/20240108033138.217032-1-wangrui@loongson.cn/

@nickdesaulniers nickdesaulniers added [PATCH] Submitted A patch has been submitted for review and removed good first issue Good for newcomers labels Jan 8, 2024
chenhuacai pushed a commit to chenhuacai/linux that referenced this issue Jan 9, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
21811e1 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux/linux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
@nathanchance
Copy link
Member

Patch accepted: https://git.kernel.org/chenhuacai/linux-loongson/c/e5517d5359715638f404c4d51418cd4431c64df6

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jan 9, 2024
chenhuacai pushed a commit to chenhuacai/linux that referenced this issue Jan 10, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
cb304d2 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux/linux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
arinc9 pushed a commit to arinc9/linux that referenced this issue Jan 10, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
e5517d5 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
shikongzhineng pushed a commit to shikongzhineng/linux that referenced this issue Jan 10, 2024
@heiher
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
ce095ca 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Gelbpunkt pushed a commit to sm8450-mainline/linux that referenced this issue Jan 11, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
4d35d6e 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jan 12, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
61352bd 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
roxell pushed a commit to roxell/linux that referenced this issue Jan 17, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
8bbf96d 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
ColinIanKing pushed a commit to ColinIanKing/linux-next that referenced this issue Jan 18, 2024
@heiher @chenhuacai
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
f58b0ab 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux/linux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
@nathanchance
Copy link
Member

Merged into mainline: https://git.kernel.org/linus/f58b0abae839f06be9d791d16196922a4b281777

@nathanchance nathanchance added [FIXED][LINUX] 6.8 This bug was fixed in Linux 6.8 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jan 24, 2024
shikongzhineng pushed a commit to shikongzhineng/linux that referenced this issue Feb 7, 2024
@heiher
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
aec88bc 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
yetist pushed a commit to loongarchlinux/linux that referenced this issue Feb 29, 2024
@heiher @yetist
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
4c1af0f 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
shikongzhineng pushed a commit to shikongzhineng/linux that referenced this issue Mar 17, 2024
@heiher
scripts/min-tool-version.sh: Raise minimum clang version to 18.0.0 fo…
4984857 
…r loongarch

The existing mainline clang development version encounters difficulties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: ClangBuiltLinux#1941
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[ARCH] loongarch This bug impacts ARCH=loongarch [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 6.8 This bug was fixed in Linux 6.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @nathanchance