Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wuninitialized in sound/soc/codecs/aw88399.c #1952

Closed
nathanchance opened this issue Oct 27, 2023 · 2 comments
Closed

-Wuninitialized in sound/soc/codecs/aw88399.c #1952

nathanchance opened this issue Oct 27, 2023 · 2 comments
Assignees
@nathanchance
Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

sound/soc/codecs/aw88399.c:441:18: error: variable 'vsense_select' is uninitialized when used here [-Werror,-Wuninitialized]
  441 |         vsense_select = vsense_select & (~AW88399_VDSEL_MASK);
      |                         ^~~~~~~~~~~~~
sound/soc/codecs/aw88399.c:431:28: note: initialize the variable 'vsense_select' to silence this warning
  431 |         unsigned int vsense_select, vsense_value;
      |                                   ^
      |                                    = 0
1 error generated.
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review -Wuninitialized [BUG] linux-next This is an issue only seen in linux-next labels Oct 27, 2023
@nathanchance nathanchance self-assigned this Oct 27, 2023
@nathanchance
Copy link
Member Author

Patch submitted: https://lore.kernel.org/20231027-asoc-aw88399-fix-wuninitialized-v1-1-b1044493e4cd@kernel.org/

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 27, 2023
@nathanchance @intel-lab-lkp
ASoC: codecs: aw88399: Fix -Wuninitialized in aw_dev_set_vcalb()
9e7c2a9 
Clang warns (or errors with CONFIG_WERROR=y):

  sound/soc/codecs/aw88399.c:441:18: error: variable 'vsense_select' is uninitialized when used here [-Werror,-Wuninitialized]
    441 |         vsense_select = vsense_select & (~AW88399_VDSEL_MASK);
        |                         ^~~~~~~~~~~~~
  sound/soc/codecs/aw88399.c:431:28: note: initialize the variable 'vsense_select' to silence this warning
    431 |         unsigned int vsense_select, vsense_value;
        |                                   ^
        |                                    = 0
  1 error generated.

This clearly should have been using the value received from
regmap_read(). Use the correct variable to resolve the warning.

Closes: ClangBuiltLinux#1952
Fixes: 8ade6cc ("ASoC: codecs: Add aw88399 amplifier driver")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
roxell pushed a commit to roxell/linux that referenced this issue Oct 31, 2023
@nathanchance @broonie
ASoC: codecs: aw88399: Fix -Wuninitialized in aw_dev_set_vcalb()
cba4590 
Clang warns (or errors with CONFIG_WERROR=y):

  sound/soc/codecs/aw88399.c:441:18: error: variable 'vsense_select' is uninitialized when used here [-Werror,-Wuninitialized]
    441 |         vsense_select = vsense_select & (~AW88399_VDSEL_MASK);
        |                         ^~~~~~~~~~~~~
  sound/soc/codecs/aw88399.c:431:28: note: initialize the variable 'vsense_select' to silence this warning
    431 |         unsigned int vsense_select, vsense_value;
        |                                   ^
        |                                    = 0
  1 error generated.

This clearly should have been using the value received from
regmap_read(). Use the correct variable to resolve the warning.

Closes: ClangBuiltLinux#1952
Fixes: 8ade6cc ("ASoC: codecs: Add aw88399 amplifier driver")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Weidong Wang <wangweidong.a@awinic.com>
Link: https://lore.kernel.org/r/20231027-asoc-aw88399-fix-wuninitialized-v1-1-b1044493e4cd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
@nathanchance
Copy link
Member Author

https://git.kernel.org/next/linux-next/c/cba4590036855f4e3110d43c14385d2401080dbb

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Submitted A patch has been submitted for review labels Oct 31, 2023
chenhuacai pushed a commit to android-la64/kernel_common that referenced this issue Dec 15, 2023
@nathanchance @gregkh
UPSTREAM: ASoC: codecs: aw88399: Fix -Wuninitialized in aw_dev_set_vc…
6e65810 
…alb()

Clang warns (or errors with CONFIG_WERROR=y):

  sound/soc/codecs/aw88399.c:441:18: error: variable 'vsense_select' is uninitialized when used here [-Werror,-Wuninitialized]
    441 |         vsense_select = vsense_select & (~AW88399_VDSEL_MASK);
        |                         ^~~~~~~~~~~~~
  sound/soc/codecs/aw88399.c:431:28: note: initialize the variable 'vsense_select' to silence this warning
    431 |         unsigned int vsense_select, vsense_value;
        |                                   ^
        |                                    = 0
  1 error generated.

This clearly should have been using the value received from
regmap_read(). Use the correct variable to resolve the warning.

Closes: ClangBuiltLinux/linux#1952
Fixes: 8ade6cc ("ASoC: codecs: Add aw88399 amplifier driver")
Change-Id: I536ba559eed5875bb155d1ed7560c572e0885e00
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Weidong Wang <wangweidong.a@awinic.com>
Link: https://lore.kernel.org/r/20231027-asoc-aw88399-fix-wuninitialized-v1-1-b1044493e4cd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit cba4590)
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance