-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Wuninitialized in drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c #220
Comments
Ah I see what's going on here.
Not sure if the warning should be fixed or hidden again. |
Probably hidden again. I think I had sent the i915 folks a patch like this before (about |
Will send it shortly then, thanks! |
@nathanchance can you please send a v2 disabling the warning for the whole subdir? |
The patch was so nice, I reviewed it twice! 🥁 |
Merged into mainline: https://git.kernel.org/torvalds/c/c5627461490e4b913e8747d3b06541e5264a50d7 |
-Wunintialized was disabled in commit c562746 ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0 (issue 415). The kernel's minimum version for LLVM is 10.0.1 so this warning can be safely enabled, where it has already caught a couple bugs. Link: ClangBuiltLinux#220 Link: ClangBuiltLinux#415 Link: ClangBuiltLinux#499 Link: llvm/llvm-project@2e04039 Link: llvm/llvm-project@c667cdc Fixes: c562746 ("drm/i915: Disable -Wuninitialized") References: 2ea4a7b ("drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show") References: 2034c21 ("drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state") Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
-Wunintialized was disabled in commit c562746 ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0 (issue 415). The kernel's minimum version for LLVM is 10.0.1 so this warning can be safely enabled, where it has already caught a couple bugs. Link: ClangBuiltLinux/linux#220 Link: ClangBuiltLinux/linux#415 Link: ClangBuiltLinux/linux#499 Link: llvm/llvm-project@2e04039 Link: llvm/llvm-project@c667cdc Fixes: c562746 ("drm/i915: Disable -Wuninitialized") References: 2ea4a7b ("drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show") References: 2034c21 ("drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state") Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20210216212953.24458-1-nathan@kernel.org (cherry picked from commit b242318) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
allyesconfig
onx86_64
The text was updated successfully, but these errors were encountered: