Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsupported flag -n in lld #340

Closed
nickdesaulniers opened this issue Jan 31, 2019 · 8 comments
Closed

unsupported flag -n in lld #340

nickdesaulniers opened this issue Jan 31, 2019 · 8 comments
Assignees
@smithp35
Labels
[ARCH] arm64 This bug impacts ARCH=arm64 [BUG] llvm A bug that should be fixed in upstream LLVM feature-request Not a bug per-se [FIXED][LLVM] 9 This bug was fixed in LLVM 9.0 [TOOL] lld The issue is relevant to LLD linker

Comments

@nickdesaulniers
Copy link
Member

nickdesaulniers commented Jan 31, 2019 •
edited by nathanchance

forked from: ClangBuiltLinux/continuous-integration#122

llvm bug: https://llvm.org/pr40542

cc @rupprecht @rui314 @smithp35 @GeorgiiR
@nickdesaulniers nickdesaulniers added [BUG] llvm A bug that should be fixed in upstream LLVM feature-request Not a bug per-se [ARCH] arm64 This bug impacts ARCH=arm64 [TOOL] lld The issue is relevant to LLD linker labels Jan 31, 2019
@nathanchance
Copy link
Member

See commit 4050740 for why it was added.

-Wl,-N may suffice but I assume the text section being read only is desirable for the kernel.

  -n, --nmagic                Do not page align data
  -N, --omagic                Do not page align data, do not make text readonly

@nathanchance nathanchance mentioned this issue Feb 3, 2019
Closed
@nathanchance
Copy link
Member

This is now a hard error as of https://git.kernel.org/arm64/linux/c/691efbedc60d2a7364a90e38882fc762f06f52c4.

https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/192907809

@smithp35
Copy link

smithp35 commented Apr 17, 2019 •
edited by nathanchance

Thanks for the report. For now I've raised https://llvm.org/pr41522 to make sure it is recorded. My suspicion is that -n can be implemented as an alias -zmax-page-size=1, although that wouldn't work for ld.bfd as there is a subtle difference in behaviour of that option (details in the PR).

@smithp35
Copy link

smithp35 commented Apr 17, 2019 •
edited by nathanchance

Sigh, looks like this was already reported as part of https://llvm.org/pr40542 I'll close my new one as a duplicate.

Just thinking it might be worth an LLD meta-bug for all the existing LLD linux kernel problems.

@nickdesaulniers nickdesaulniers mentioned this issue Apr 19, 2019
Closed
@nickdesaulniers
Copy link
Member Author

I spoke more with @smithp35 about this, sounds like it's feasible to implement. Should be the final arm64+LLD issue.

@smithp35
Copy link

I've made an attempt at -n with https://reviews.llvm.org/D61201 proved to be a bit more difficult than I thought. It is also worth mentioning that -n will need a linker script (vdso does have one!) to get a sensible output.

@tpimh tpimh added the [PATCH] Submitted A patch has been submitted for review label Apr 27, 2019
@nathanchance nathanchance mentioned this issue Apr 29, 2019
Merged
@nathanchance
Copy link
Member

New patch: https://reviews.llvm.org/D61688

@nickdesaulniers
Copy link
Member Author

big thanks @smithp35 : https://reviews.llvm.org/rL360593

@nickdesaulniers nickdesaulniers added [FIXED][LLVM] 9 This bug was fixed in LLVM 9.0 and removed [PATCH] Submitted A patch has been submitted for review labels May 13, 2019
raphielscape pushed a commit to RaphielGang/disrupt_kernel_xiaomi_sdm845 that referenced this issue Dec 13, 2019
@nickdesaulniers @raphielscape
ANDROID: arm64: vdso: guard against -Wl,-n
22325a3 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
kholk pushed a commit to kholk/kernel that referenced this issue Dec 18, 2019
@nickdesaulniers @kholk
ANDROID: arm64: vdso: guard against -Wl,-n
ff7326c 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
kholk pushed a commit to kholk/kernel that referenced this issue Dec 19, 2019
@nickdesaulniers @kholk
ANDROID: arm64: vdso: guard against -Wl,-n
224ebb5 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
raphielscape pushed a commit to RaphielGang/disrupt_kernel_xiaomi_sdm845 that referenced this issue Jan 8, 2020
@nickdesaulniers @raphielscape
ANDROID: arm64: vdso: guard against -Wl,-n
d5d7135 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
najahiiii pushed a commit to chips-project/msm-4.14 that referenced this issue Jan 14, 2020
@nickdesaulniers @najahiiii
ANDROID: arm64: vdso: guard against -Wl,-n
1282889 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
najahiiii pushed a commit to chips-project/msm-4.14 that referenced this issue Jan 28, 2020
@nickdesaulniers @najahiiii
ANDROID: arm64: vdso: guard against -Wl,-n
e9057b4 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Re4son pushed a commit to Re4son/android_kernel_oneplus_sm8150 that referenced this issue Mar 8, 2020
@nickdesaulniers @holyangel
ANDROID: arm64: vdso: guard against -Wl,-n
ff39488 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
raphielscape pushed a commit to RaphielGang/disrupt_kernel_xiaomi_sdm845 that referenced this issue Mar 16, 2020
@nickdesaulniers @raphielscape
ANDROID: arm64: vdso: guard against -Wl,-n
3cf124c 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
nathanchance pushed a commit that referenced this issue Mar 22, 2020
@torvalds
mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case
d41e2f3 
In section_deactivate(), pfn_to_page() doesn't work any more after
ms->section_mem_map is resetting to NULL in SPARSEMEM|!VMEMMAP case.  It
causes a hot remove failure:

  kernel BUG at mm/page_alloc.c:4806!
  invalid opcode: 0000 [#1] SMP PTI
  CPU: 3 PID: 8 Comm: kworker/u16:0 Tainted: G        W         5.5.0-next-20200205+ #340
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015
  Workqueue: kacpi_hotplug acpi_hotplug_work_fn
  RIP: 0010:free_pages+0x85/0xa0
  Call Trace:
   __remove_pages+0x99/0xc0
   arch_remove_memory+0x23/0x4d
   try_remove_memory+0xc8/0x130
   __remove_memory+0xa/0x11
   acpi_memory_device_remove+0x72/0x100
   acpi_bus_trim+0x55/0x90
   acpi_device_hotplug+0x2eb/0x3d0
   acpi_hotplug_work_fn+0x1a/0x30
   process_one_work+0x1a7/0x370
   worker_thread+0x30/0x380
   kthread+0x112/0x130
   ret_from_fork+0x35/0x40

Let's move the ->section_mem_map resetting after
depopulate_section_memmap() to fix it.

[akpm@linux-foundation.org: remove unneeded initialization, per David]
Fixes: ba72b4c ("mm/sparsemem: support sub-section hotplug")
Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200307084229.28251-2-bhe@redhat.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
subhajeetmuhuri pushed a commit to AOSiP-Devices/kernel_xiaomi_sdm660 that referenced this issue Mar 24, 2020
@nickdesaulniers @subhajeetmuhuri
ANDROID: arm64: vdso: guard against -Wl,-n
ca8d166 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 7, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
8a496fe 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 7, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
26ae931 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
ravindu644 pushed a commit to ravindu644/android_kernel_beyondx_lpos that referenced this issue Feb 9, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
f7d2965 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu644 pushed a commit to ravindu644/android_kernel_beyond1_lpos that referenced this issue Feb 9, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
c95778e 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 21, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
065bd3a 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 22, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
8951362 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 22, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
f79d86d 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 22, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
cd5ec54 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 25, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
7eaa9e0 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 25, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
65c246b 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 25, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
f52f2ed 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
SwapnilVicky pushed a commit to SwapnilVicky/namaste_xiaomi_miatoll that referenced this issue Feb 26, 2024
@nickdesaulniers @SwapnilVicky
ANDROID: arm64: vdso: guard against -Wl,-n
e11050a 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
ravindu644 pushed a commit to ravindu644/android_kernel_beyond0 that referenced this issue Feb 29, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
011513e 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ekkusa pushed a commit to miyoubi/kernel_sony_sdm845 that referenced this issue Mar 11, 2024
@nickdesaulniers @ekkusa
ANDROID: arm64: vdso: guard against -Wl,-n
9ce6d05 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Signed-off-by: CloudedQuartz <ravenklawasd@gmail.com>
Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
ekkusa pushed a commit to miyoubi/kernel_sony_sdm845 that referenced this issue Mar 12, 2024
@nickdesaulniers @ekkusa
ANDROID: arm64: vdso: guard against -Wl,-n
4532690 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Signed-off-by: CloudedQuartz <ravenklawasd@gmail.com>
Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
ExtremeXT pushed a commit to ExtremeXT/android_kernel_samsung_exynos990 that referenced this issue Mar 18, 2024
@nickdesaulniers @ExtremeXT
ANDROID: arm64: vdso: wrap -n in ld-option
233336a 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu644 pushed a commit to ravindu644/android_kernel_lpos_d1 that referenced this issue Mar 20, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
901b1bd 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu644 pushed a commit to ravindu644/android_kernel_samsung_sm_n975 that referenced this issue Mar 21, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
fc8c31b 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu755 pushed a commit to ravindu644/android_kernel_beyondx_lpos that referenced this issue Mar 22, 2024
@nickdesaulniers @ravindu755
ANDROID: arm64: vdso: wrap -n in ld-option
2892d73 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu755 pushed a commit to ravindu644/android_kernel_beyondx_lpos that referenced this issue Mar 25, 2024
@nickdesaulniers @ravindu755
ANDROID: arm64: vdso: wrap -n in ld-option
ef60edd 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu755 pushed a commit to ravindu644/android_kernel_beyondx_lpos that referenced this issue Mar 25, 2024
@nickdesaulniers @ravindu755
ANDROID: arm64: vdso: wrap -n in ld-option
0831a6d 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ghazzor pushed a commit to ghazzor/kernel_samsung_M215F_CVH1 that referenced this issue Mar 25, 2024
@nickdesaulniers @ghazzor
ANDROID: arm64: vdso: wrap -n in ld-option
7655011 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu644 pushed a commit to ravindu644/android_kernel_beyondx_lpos that referenced this issue Mar 26, 2024
@nickdesaulniers @ravindu644
ANDROID: arm64: vdso: wrap -n in ld-option
849d0ec 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
ravindu755 pushed a commit to ravindu644/android_kernel_beyond2 that referenced this issue Mar 26, 2024
@nickdesaulniers @ravindu755
ANDROID: arm64: vdso: wrap -n in ld-option
e9ce2a0 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
Creeeeger pushed a commit to Creeeeger/Galaxy_S10_5G_Kernel that referenced this issue Apr 3, 2024
@nickdesaulniers @Creeeeger
ANDROID: arm64: vdso: wrap -n in ld-option
6fa5da0 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
dhelo11 pushed a commit to dhelo11/XyL_kernel_santoni_4.9 that referenced this issue Apr 7, 2024
@nickdesaulniers
ANDROID: arm64: vdso: guard against -Wl,-n
3ac36d2 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Coptan99 pushed a commit to Coptan99/android_kernel_xiaomi_sdm660-4.4 that referenced this issue Apr 16, 2024
@nickdesaulniers @Coptan99
ANDROID: arm64: vdso: guard against -Wl,-n
ed08bb0 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Signed-off-by: GhostMaster69-dev <rathore6375@gmail.com>
Signed-off-by: ironman-reborn <ironman-reborn@users.noreply.github.com>
Signed-off-by: GhostMaster69-dev <rathore6375@gmail.com>
Signed-off-by: Omar Mohamed <omarcoptan9@gmail.com>
ghazzor pushed a commit to ghazzor/grass_kernel that referenced this issue Apr 19, 2024
@nickdesaulniers @ghazzor
ANDROID: arm64: vdso: wrap -n in ld-option
831535f 
ld.lld distributed in clang-r353983c AOSP LLVM release (the final AOSP
LLVM release for Android Q) did not support `-n` linker flag. It was
eventually added to clang-r360593.

Android OEM's may wish to still use ld.lld to link their kernels for Q.
This flag was disabled for Pixel 4 in go/pag/1258086. This patch is
equivalent, but rebased on upstream changes that removed cc-ldoption in
favor of ld-option.

For Android R, the final AOSP LLVM release, clang-r383902 has long
supported `-n` for ld.lld.

Change-Id: Iab41c9e1039e163113b428fc487a4a0708822faa
Bug: 63740206
Bug: 157279372
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
Sorayukii pushed a commit to Sorayukii/kernel_tama_clo that referenced this issue Apr 23, 2024
@nickdesaulniers @Sorayukii
ANDROID: arm64: vdso: guard against -Wl,-n
313ba4a 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Signed-off-by: CloudedQuartz <ravenklawasd@gmail.com>
Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
Sorayukii pushed a commit to Sorayukii/kernel_tama_clo that referenced this issue Apr 24, 2024
@nickdesaulniers @Sorayukii
ANDROID: arm64: vdso: guard against -Wl,-n
1f5391e 
LLD does not yet support it.

Bug: 63740206
Link: ClangBuiltLinux/linux#340
Link: https://bugs.llvm.org/show_bug.cgi?id=40542
Change-Id: Id62a3631b2da130a44ae018ddf4a2e8d095c16d7
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yousef Algadri <yusufgadrie@gmail.com>
Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Rapherion Rollerscaperers <rapherion@raphielgang.org>
Signed-off-by: Twisted <36546624+TwistedPrime@users.noreply.github.com>
Signed-off-by: MadeOfGreat <ravenklawasd@gmail.com>
Signed-off-by: CloudedQuartz <ravenklawasd@gmail.com>
Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smithp35 smithp35

Labels
[ARCH] arm64 This bug impacts ARCH=arm64 [BUG] llvm A bug that should be fixed in upstream LLVM feature-request Not a bug per-se [FIXED][LLVM] 9 This bug was fixed in LLVM 9.0 [TOOL] lld The issue is relevant to LLD linker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tpimh @nickdesaulniers @nathanchance @smithp35