Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolchain build scripts #434

Closed
nathanchance opened this issue Mar 27, 2019 · 6 comments
Closed

Toolchain build scripts #434

nathanchance opened this issue Mar 27, 2019 · 6 comments
Assignees
@nathanchance
Labels
announcement just a heads up infrastructure Not a bug per se, but an improvement to our workflow question Question asked by issue author.

Comments

@nathanchance
Copy link
Member

I've gone ahead and created a set of build scripts to build LLVM, clang, ld.lld, and binutils from source. This was inspired by issues like #337 (which spawned our wiki page), #358, and this thread. This can help get people involved (since I've designed it to be fairly self contained by default so people don't have to arbitrarily add repos to their package manager to get a newer build of clang/ld.lld).

The repo is here: https://github.com/nathanchance/tc-build

I'd like to bring this into our organization and I am happy to take ownership of it, I just want people to be okay with that and review it to see if there are any major objections.
@nathanchance nathanchance added question Question asked by issue author. infrastructure Not a bug per se, but an improvement to our workflow announcement just a heads up labels Mar 27, 2019
@nathanchance nathanchance self-assigned this Mar 27, 2019
@dileks
Copy link
Collaborator

dileks commented Mar 27, 2019

Rating: Wonder+Full

@nickdesaulniers
Copy link
Member

I'd like to bring this into our organization and I am happy to take ownership of it

Sounds great! Go for it. Can you create the empty project under the org, then issue a PR so we can do code review (rather than full blown import)?

I just want people to be okay with that and review it to see if there are any major objections.

Would you mind just putting the license block in a LICENSE file rather than specifying at the top of a new file (I find that a PITA otherwise).

@nathanchance
Copy link
Member Author

Sure to both.

@nathanchance
Copy link
Member Author

ClangBuiltLinux/tc-build#1

@nathanchance
Copy link
Member Author

ClangBuiltLinux/tc-build#2

The scripts were rewritten in Python, if people want to give it a test.

@nathanchance
Copy link
Member Author

Updated the wiki accordingly: https://github.com/ClangBuiltLinux/linux/wiki/Building-Clang-from-source

nathanchance pushed a commit that referenced this issue Aug 2, 2020
@jpbrucker @borkmann
selftests/bpf: Fix cgroup sockopt verifier test
55b2442 
Since the BPF_PROG_TYPE_CGROUP_SOCKOPT verifier test does not set an
attach type, bpf_prog_load_check_attach() disallows loading the program
and the test is always skipped:

 #434/p perfevent for cgroup sockopt SKIP (unsupported program type 25)

Fix the issue by setting a valid attach type.

Fixes: 0456ea1 ("bpf: Enable more helpers for BPF_PROG_TYPE_CGROUP_{DEVICE,SYSCTL,SOCKOPT}")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/20200710150439.126627-1-jean-philippe@linaro.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
announcement just a heads up infrastructure Not a bug per se, but an improvement to our workflow question Question asked by issue author.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dileks @nickdesaulniers @nathanchance