Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-variable in drivers/watchdog/digicolor_wdt.c #591

Closed
nickdesaulniers opened this issue Jul 9, 2019 · 2 comments
Closed

-Wunused-variable in drivers/watchdog/digicolor_wdt.c #591

nickdesaulniers opened this issue Jul 9, 2019 · 2 comments
Assignees
@nathanchance
Labels
-Wunused-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org>

Comments

@nickdesaulniers
Copy link
Member

Reported-by: kernelci.org bot bot@kernelci.org

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret' [-Wunused-variable]
@nickdesaulniers nickdesaulniers added good first issue Good for newcomers [ARCH] arm64 This bug impacts ARCH=arm64 low priority This bug is not critical and not a priority [BUG] linux-next This is an issue only seen in linux-next -Wunused-variable labels Jul 9, 2019
@nathanchance
Copy link
Member

Patch sent: https://lore.kernel.org/lkml/20190709203409.117123-1-natechancellor@gmail.com/

@nathanchance nathanchance self-assigned this Jul 9, 2019
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review and removed good first issue Good for newcomers low priority This bug is not critical and not a priority labels Jul 9, 2019
@nathanchance
Copy link
Member

Fixed: https://git.kernel.org/next/linux-next/c/7fb832ae72949c883da52d6316ff08f03c75d300

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Submitted A patch has been submitted for review labels Jul 16, 2019
avagin pushed a commit to avagin/linux that referenced this issue Jul 16, 2019
@nathanchance
watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe
7fb832a 
clang warns:

drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
[-Wunused-variable]
        int ret;
            ^
1 warning generated.

It's unused now, remove it.

Fixes: cdad269 ("watchdog: digicolor_wdt: drop warning after registering device")
Link: ClangBuiltLinux/linux#591
Reported-by: kernelci.org bot <bot@kernelci.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20190709203409.117123-1-natechancellor@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
@nickdesaulniers nickdesaulniers added the [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org> label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wunused-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org>
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @nathanchance