Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wincompatible-function-pointer-types in drivers/remoteproc/mtk_scp.c #927

Closed
nathanchance opened this issue Mar 10, 2020 · 2 comments
Closed

-Wincompatible-function-pointer-types in drivers/remoteproc/mtk_scp.c #927

nathanchance opened this issue Mar 10, 2020 · 2 comments
Assignees
@nathanchance
Labels
-Wincompatible-pointer-types [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka 'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an expression of type 'void *(struct rproc *, u64, int)' (aka 'void *(struct rproc *, unsigned long long, int)') [-Werror,-Wincompatible-function-pointer-types]
        .da_to_va       = scp_da_to_va,
                          ^~~~~~~~~~~~
1 error generated.

Patch submitted: https://lore.kernel.org/lkml/20200310211514.32288-1-natechancellor@gmail.com/
@nathanchance nathanchance self-assigned this Mar 10, 2020
@nathanchance nathanchance added [BUG] linux-next This is an issue only seen in linux-next [PATCH] Submitted A patch has been submitted for review labels Mar 10, 2020
fengguang pushed a commit to 0day-ci/linux that referenced this issue Mar 10, 2020
@nathanchance @intel-lab-lkp
remoteproc/mediatek: Use size_t type for len in scp_da_to_va
ea48afa 
Clang errors:

drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function
pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka
'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an
expression of type 'void *(struct rproc *, u64, int)' (aka 'void
*(struct rproc *, unsigned long long, int)')
[-Werror,-Wincompatible-function-pointer-types]
        .da_to_va       = scp_da_to_va,
                          ^~~~~~~~~~~~
1 error generated.

Make the same change as commit 0fcbb36 ("remoteproc: Use size_t
type for len in da_to_va"), which was not updated for the acceptance of
commit 63c13d6 ("remoteproc/mediatek: add SCP support for mt8183").

Fixes: 0fcbb36 ("remoteproc: Use size_t type for len in da_to_va")
Link: ClangBuiltLinux#927
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@nathanchance
Copy link
Member Author

Patch accepted: https://git.kernel.org/andersson/remoteproc/c/18101380c160ec0787e77656106812baa2995f9c

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Mar 10, 2020
staging-kernelci-org pushed a commit to kernelci/linux that referenced this issue Mar 11, 2020
@nathanchance @andersson
remoteproc/mediatek: Use size_t type for len in scp_da_to_va
1810138 
Clang errors:

drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function
pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka
'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an
expression of type 'void *(struct rproc *, u64, int)' (aka 'void
*(struct rproc *, unsigned long long, int)')
[-Werror,-Wincompatible-function-pointer-types]
        .da_to_va       = scp_da_to_va,
                          ^~~~~~~~~~~~
1 error generated.

Make the same change as commit 0fcbb36 ("remoteproc: Use size_t
type for len in da_to_va"), which was not updated for the acceptance of
commit 63c13d6 ("remoteproc/mediatek: add SCP support for mt8183").

Fixes: 0fcbb36 ("remoteproc: Use size_t type for len in da_to_va")
Link: ClangBuiltLinux#927
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20200310211514.32288-1-natechancellor@gmail.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/next/linux-next/c/18101380c160ec0787e77656106812baa2995f9c

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Mar 11, 2020
sumananna pushed a commit to sumananna/remoteproc that referenced this issue Mar 26, 2020
@nathanchance @andersson
remoteproc/mediatek: Use size_t type for len in scp_da_to_va
e1833b9 
Clang errors:

drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function
pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka
'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an
expression of type 'void *(struct rproc *, u64, int)' (aka 'void
*(struct rproc *, unsigned long long, int)')
[-Werror,-Wincompatible-function-pointer-types]
        .da_to_va       = scp_da_to_va,
                          ^~~~~~~~~~~~
1 error generated.

Make the same change as commit 0fcbb36 ("remoteproc: Use size_t
type for len in da_to_va"), which was not updated for the acceptance of
commit 63c13d6 ("remoteproc/mediatek: add SCP support for mt8183").

Fixes: 0fcbb36 ("remoteproc: Use size_t type for len in da_to_va")
Link: ClangBuiltLinux/linux#927
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20200310211514.32288-1-natechancellor@gmail.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@nathanchance
UPSTREAM: remoteproc/mediatek: Use size_t type for len in scp_da_to_va
9c392a7 
Clang errors:

drivers/remoteproc/mtk_scp.c:364:14: error: incompatible function
pointer types initializing 'void *(*)(struct rproc *, u64, size_t)' (aka
'void *(*)(struct rproc *, unsigned long long, unsigned int)') with an
expression of type 'void *(struct rproc *, u64, int)' (aka 'void
*(struct rproc *, unsigned long long, int)')
[-Werror,-Wincompatible-function-pointer-types]
        .da_to_va       = scp_da_to_va,
                          ^~~~~~~~~~~~
1 error generated.

Make the same change as commit 0fcbb36 ("remoteproc: Use size_t
type for len in da_to_va"), which was not updated for the acceptance of
commit 63c13d6 ("remoteproc/mediatek: add SCP support for mt8183").

Fixes: 0fcbb36 ("remoteproc: Use size_t type for len in da_to_va")
Link: ClangBuiltLinux#927
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20200310211514.32288-1-natechancellor@gmail.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
(cherry picked from commit e1833b9)

BUG=b:152827561
TEST=Connect wifi on Trogdor

Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: Ibfb44df99d03fd266b9934700dab85fdb07d43f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2125078
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wincompatible-pointer-types [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance