Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils.py: Bump binutils to v2.35.1 and use sha512sum (v2) #120

Conversation

dileks
Copy link
Contributor

@dileks dileks commented Sep 24, 2020

Bump binutils to version 2.35.1 and use SHA512 checksum as upstream provides a sha512.sum file.

Run (here: x86-64):

$ python3 ./build-binutils.py -B ~/src/llvm-toolchain/build -I ~/src/llvm-toolchain/install -t x86_64-linux-gnu

Link: https://sourceware.org/pub/binutils/releases/sha512.sum
Link: https://sourceware.org/pipermail/binutils/2020-September/113375.html
Link: #118
Signed-off-by: Sedat Dilek sedat.dilek@gmail.com

Bump binutils to version 2.35.1 and use SHA512 checksum as upstream provides a sha512.sum file.

Run (here: x86-64):

$ python3 ./build-binutils.py -B ~/src/llvm-toolchain/build -I ~/src/llvm-toolchain/install -t x86_64-linux-gnu

Link: https://sourceware.org/pub/binutils/releases/sha512.sum
Link: https://sourceware.org/pipermail/binutils/2020-September/113375.html
Link: ClangBuiltLinux#118
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
@msfjarvis
Copy link
Member

You can just force push the branch rather than create new pull requests for each revision

@msfjarvis
Copy link
Member

msfjarvis commented Sep 24, 2020

To fix the yapf violation you'll need to run yapf -i utils.py in the repository after installing it.

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

@msfjarvis

run yapf -i utils.py in the repository - Run where? Here in my local Git?

@msfjarvis
Copy link
Member

@msfjarvis

run yapf -i utils.py in the repository - Run where? Here in my local Git?

Yes, commit the result of that and push it.

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

I have installed python3-yapfDebian package.

But I cannot run yapf -i utils.py.

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

root# apt-get install -y python3-yapf yapf3

dileks$ cd tc-build.dileks
dileks$ yapf3 -i utils.py

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

I did:

$ yapf3 -i -vv utils.py
Reformatting utils.py

dileks@iniza:~/src/llvm-toolchain/tc-build$ git push --force --set-upstream origin dileks/bump-binutils-to-2_35_1-and-use-sha512sum-v2
Branch 'dileks/bump-binutils-to-2_35_1-and-use-sha512sum-v2' folgt nun Remote-Branch 'dileks/bump-binutils-to-2_35_1-and-use-sha512sum-v2' von 'origin'.
Everything up-to-date

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

Can we document that yapfis needed to format python code before doing a pull-request?

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

Lint checks / yapf (pull_request) still fails - I just re-run the checks here.

@dileks
Copy link
Contributor Author

dileks commented Sep 24, 2020

Installed:

$ yapf3 --version
yapf 0.29.0

@dileks dileks closed this Sep 24, 2020
@dileks dileks deleted the dileks/bump-binutils-to-2_35_1-and-use-sha512sum-v2 branch September 24, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants