Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print total script durations #222

Merged
merged 2 commits into from Jan 23, 2023
Merged

Print total script durations #222

merged 2 commits into from Jan 23, 2023

Conversation

nathanchance
Copy link
Member

Closes: #221

@nathanchance nathanchance mentioned this pull request Jan 22, 2023
Closed
@nathanchance
tc-build: Add custom duration printing function
5e95db2 
Right now, datetime.timedelta() is used for printing how long something
took. While there is nothing functionally wrong with this, the format it
prints is a little condensed and hard to quickly parse. Having some
separation between the numbers and unit labels can make things clearer.

This changes the format of the current duration like:

  11:58:59

to:

  11h 58m 59s

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
@nathanchance
tc-build: Print total script durations
1a2705c 
Closes: ClangBuiltLinux#221
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
@nathanchance nathanchance changed the title build-llvm.py: Print total script duration Print total script durations Jan 22, 2023
@nathanchance
Copy link
Member Author

I added a better (IMO, that is) duration formatting function and applied it to build-binutils.py as well.

@nathanchance nathanchance merged commit 917d1be into ClangBuiltLinux:main Jan 23, 2023
@nathanchance nathanchance deleted the print-total-duration branch January 23, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfjarvis msfjarvis msfjarvis approved these changes

@nickdesaulniers nickdesaulniers Awaiting requested review from nickdesaulniers

@stephenhines stephenhines Awaiting requested review from stephenhines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display total build-time
2 participants
@nathanchance @msfjarvis