Three miscellaneous improvements #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
stephenhines
as code owners
|
what are all the patch files for? |
|
We need them to build arm/arm64 allyesconfig succesfully, due to:
and the two sounds commits fix https://git.kernel.org/linus/164a263bf8d003e4cbb197d52b74d26df72604d7, which causes errors on arm64 allyesconfig because of x86 specific header files. |
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
This script is a handy benchmarking tool for testing the time differences in various clang configurations. I've already used it to see how much speedup we get with PGO and how much slow down to expect with assertions enabled. On Linux 5.2, we need just four patches to make everything build properly (and two of them are upstream for 5.3), see the patch file for any issues. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
force-pushed
the
misc-improvements
branch
from
6820513
to
deca237
Compare
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
changed the title
|
Gentle ping for review :) |
msfjarvis
approved these changes
Jul 24, 2019
|
Can we start getting some of these merged? |
|
I think we should merge these Monday afternoon (will give a bit of last minute review/testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes a couple of shellcheck warnings.
The second patch allows the kernel build script to do allyesconfig builds, which can be helpful for benchmarking changes like PGO and adding assertions. The commit message explains more.
The third patch just formats
utils.pywith YAPF.Let me know if there are any concerns.