build-llvm.py: Add '--assertions' #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with llvm/llvm-project@5354c83 that only appears when assertions are enabled (because it only adds an assertion). Add a way to turn them on in a release configuration so that compiles are still relatively quick. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
stephenhines
as code owners
msfjarvis
approved these changes
Jul 27, 2019
|
I am going to respin this with the idea I had in #42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with llvm/llvm-project@5354c83 that only appears when
assertions are enabled (because it only adds an assertion). Add a way to
turn them on in a release configuration so that compiles are still
relatively quick.