SRK not reading critical temperature (Tc)

[NicolasHeredia]

Hello and thank you in advance.

I'm trying to create an SRK model with a custom database.

model_nh = SRK(["metanol", "benceno"]; userlocations=["database/"], alpha_userlocations = ["database/"])

And I did get:

cannot found any values for Tc.

Searching the SRK source code I found that the "userlocations" argument is not being passed to RK.
https://github.com/ClapeyronThermo/Clapeyron.jl/blob/4136658d31edbbfde794fbefd588024d9ddd79a2/src/models/cubic/RK/variants/SRK.jl

Could that be the problem?

[longemen3000]

yes, you are right!
in the meantime, you could use RK(["metanol", "benceno"]; userlocations=["database/"], alpha = SoaveAlpha, alpha_userlocations = ["database/"])

[pw0908]

Is this problem unique to SRK?

[longemen3000]

i remember doing a check a while ago for derived models, it seems that SRK just passed through the cracks

[pw0908]

QCPR might have that problem?

[longemen3000]

not directly, the userlocations got added here:

Clapeyron.jl/src/models/cubic/PR/variants/QCPR.jl

Line 26 in 4842741

QCPR_userlocations = vcat("@REMOVEDEFAULTS","@DB/cubic/QCPR/QCPR_critical.csv", "@DB/cubic/QCPR/QCPR_unlike.csv",userlocations)

, but verbose was not considered

[pw0908]

Cool, so we can close this issue now

[NicolasHeredia]

Thank you for your answers