Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite correlation models #118

Merged
merged 45 commits into from
Oct 6, 2022
Merged

Composite correlation models #118

merged 45 commits into from
Oct 6, 2022

Conversation

longemen3000
Copy link
Member

@longemen3000 longemen3000 commented Sep 29, 2022

This adds initial support for "Composite correlation models" what is this? basically a model that holds liquid, gas and saturation models. it is useful in assisting other models, like activity models. the end goal would be to make γ-ϕ equilibria.
it also introduces some auxiliary EoSModels (SaturationModel, LiquidVolumeModel) that will be required for #117 (specially LiquidVolumeModel)
What is missing:

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Base: 83.55% // Head: 81.12% // Decreases project coverage by -2.43% ⚠️

Coverage data is based on head (49cdc67) compared to base (47d3e06).
Patch coverage: 25.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   83.55%   81.12%   -2.44%     
==========================================
  Files         184      196      +12     
  Lines       11782    12177     +395     
==========================================
+ Hits         9845     9879      +34     
- Misses       1937     2298     +361     
Impacted Files Coverage Δ
src/database/ParamOptions.jl 100.00% <ø> (ø)
src/database/params/AssocParam.jl 36.92% <0.00%> (-21.62%) ⬇️
src/methods/property_solvers/volume.jl 93.47% <ø> (-0.08%) ⬇️
src/models/CompositeModel/CompositeModel.jl 0.00% <0.00%> (ø)
...ompositeModel/LiquidVolumeModel/COSTALD/costald.jl 0.00% <0.00%> (ø)
...LiquidVolumeModel/DIPPR105Liquid/DIPPR105Liquid.jl 0.00% <0.00%> (ø)
...teModel/LiquidVolumeModel/Rackett/RackettLiquid.jl 0.00% <0.00%> (ø)
src/models/Virial/AbbottVirial/AbbottVirial.jl 0.00% <0.00%> (ø)
src/models/Virial/EoSVirial/EoSVirial.jl 0.00% <0.00%> (ø)
...dels/Virial/TsonopoulosVirial/TsonopoulosVirial.jl 0.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@longemen3000 longemen3000 merged commit 9f3090e into master Oct 6, 2022
@longemen3000 longemen3000 deleted the CompositeModel branch October 31, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants