Saf tgamma mie #12
Merged
Saf tgamma mie #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All N have been changed to z (the code does work with the modification to macros). All kB have been removed from a1, a2 and a3 terms. There is still an inconsistency between SAFTVRMie and SAFTgammaMie likely relating to the a1_S term. To be addressed.
Errors in the lambdas have been addressed and the epsilon has been added to the a2 term.
Van der waals eos has been added to the eos library; still needs to be benchmarked.
vdW, RK, SRK and PR have all been added and benchmarked. Parameters could be cleaned up and CPA is still left to be added.
SAFT gamma mie benchmark has been start; the chain term now runs with g_HS being correct. g_1 and g_2 still have errors.
The chain term has been benchmarked. Methods will have to be modified to be compatible with gc eos.
After consolodating the methods codes, all eos now use the same code but initial guesses are calculated in a separate function. SAFTgammaMie calculations are now functional; example notebooks to follow!
|
after this branch is merged, im going to port some methods of utility and speed up the package in general |
SAFT-VRQ Mie has been coded and benchmarked; further modifications will be required to optimise the code (avoid repeated calculations, etc.).
…nto SAFTgammaMie
CPA has been coded and benchmarked; may not yet be ready for mixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.