Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all Single Empiric Helmoltz models under one struct #148

Merged
merged 109 commits into from
Jul 1, 2023

Merge branch 'singlefluid-common' of https://github.com/ypaul21/Clape…

b7cda04
Select commit
Loading
Failed to load commit list.
Merged

Unify all Single Empiric Helmoltz models under one struct #148

Merge branch 'singlefluid-common' of https://github.com/ypaul21/Clape…
b7cda04
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 1, 2023 in 1s

82.89% (-2.82%) compared to 86b8464

View this Pull Request on Codecov

82.89% (-2.82%) compared to 86b8464

Details

Codecov Report

Merging #148 (b7cda04) into master (86b8464) will decrease coverage by 2.82%.
The diff coverage is 63.11%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   85.70%   82.89%   -2.82%     
==========================================
  Files         222      244      +22     
  Lines       15110    15991     +881     
==========================================
+ Hits        12950    13255     +305     
- Misses       2160     2736     +576     
Impacted Files Coverage Δ
ext/ClapeyronSymbolicsExt.jl 0.00% <0.00%> (ø)
src/Clapeyron.jl 100.00% <ø> (ø)
src/database/combiningrules/outplace.jl 100.00% <ø> (ø)
src/methods/methods.jl 63.29% <ø> (-3.80%) ⬇️
src/methods/stability.jl 13.11% <ø> (ø)
src/models/Activity/COSMOSAC/COSMOSAC02.jl 96.29% <0.00%> (-3.71%) ⬇️
src/models/Activity/COSMOSAC/COSMOSAC10.jl 95.94% <0.00%> (-4.06%) ⬇️
src/models/Activity/COSMOSAC/COSMOSACdsp.jl 80.00% <0.00%> (-6.49%) ⬇️
...lmholtz/MultiFluid/departure/QuadraticDeparture.jl 0.00% <0.00%> (ø)
...models/EmpiricHelmholtz/MultiFluid/departure/TL.jl 0.00% <0.00%> (ø)
... and 59 more

... and 19 files with indirect coverage changes