Update cosmosac #204
Merged
Update cosmosac #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 83.16% 82.02% -1.14%
==========================================
Files 251 258 +7
Lines 16150 16572 +422
==========================================
+ Hits 13431 13594 +163
- Misses 2719 2978 +259
|
|
That makes sense to me. I would recommend a strong comment in the docs, perhaps a print statement in the console that you must manually silence, indicating the license terms within which the COSMO-SAC files are made available. They are not allowed to be used for all purposes. |
|
Great! I've changed the implementation so that users must intentionally select the nist database to use it, at which point a warning is thrown to let them know to check the license. The docs themselves are getting an overhaul on a separate branch where I've added similar warnings. |
longemen3000
approved these changes
Sep 22, 2023
|
test fail is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionalities where, if COSMO-SAC parameters are not in the Clapeyron database, they will be looked up in the NIST/COSMOSAC database.
@ianhbell do you have any opposition to this? We can add the relevant references to the model to ensure both your database and the folks who built the database receive the appropriate recognition.