Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JutulDarcy.jl extension #227

Merged
merged 25 commits into from
Nov 6, 2023
Merged

JutulDarcy.jl extension #227

merged 25 commits into from
Nov 6, 2023

Conversation

longemen3000
Copy link
Member

allows integration between Clapeyron.jl and JutulDarcy.jl simulation toolkit. adds improvements on the already existing MultiComponentFlash.jl integration. depends on sintefmath/JutulDarcy.jl#24, but is ready to merge

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #227 (5aeab69) into master (448bfe1) will decrease coverage by 1.27%.
The diff coverage is 19.60%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   81.71%   80.44%   -1.27%     
==========================================
  Files         268      274       +6     
  Lines       17646    17927     +281     
==========================================
+ Hits        14420    14422       +2     
- Misses       3226     3505     +279     
Files Coverage Δ
ext/MultiComponentFlash/Clapeyron_flash.jl 100.00% <100.00%> (ø)
ext/MultiComponentFlash/stability.jl 94.73% <94.73%> (ø)
src/methods/property_solvers/volume.jl 80.55% <0.00%> (-12.00%) ⬇️
src/modules/solvers/ad.jl 66.32% <0.00%> (-11.06%) ⬇️
ext/ClapeyronMultiComponentFlashExt.jl 22.22% <0.00%> (-58.40%) ⬇️
ext/ClapeyronJutulDarcyExt.jl 0.00% <0.00%> (ø)
ext/MultiComponentFlash/flow_coupler.jl 0.00% <0.00%> (ø)
ext/MultiComponentFlash/viscosity.jl 0.00% <0.00%> (ø)
ext/MultiComponentFlash/flash.jl 32.69% <32.69%> (ø)

... and 1 file with indirect coverage changes

@longemen3000 longemen3000 merged commit 63dd5da into master Nov 6, 2023
19 of 24 checks passed
@pw0908 pw0908 deleted the jutuldarcy-ext branch November 30, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants