minor typo in the PT_flash function for the bubble point case #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!, it is really a work in progress at the moment, more updates will come in the following days, but I will merge anyway |
pw0908
pushed a commit
that referenced
this pull request
Apr 28, 2022
minor typo in the PT_flash function for the bubble point case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pw0908
Thank you for implementing PT_flash functionality. I was eagerly waiting for it.
Looks like there was a minor typo which was causing the PT_flash function fail when encountering bubble point condition.
Please see if this pull request is OK and would fix it.
Thanks and Regards
Ramesh Putalapattu