-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSV.jl deprecations #46
Conversation
API changed in JuliaData/CSV.jl#837, which is [included in v0.9](https://github.com/JuliaData/CSV.jl/releases/tag/v0.9.0) - CSV.jl compat bounds need to be updated accordingly.
Nice!, can you up the package version from 0.2.2 to 0.2.3? |
Mmm, the errors are relevant |
Yep, working on a fix.
…On Fri, Oct 8, 2021 at 1:50 PM Andrés Riedemann ***@***.***> wrote:
Mmm, the errors are relevant
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA73GELYFPQ5XBSTKWUOZLUF44OFANCNFSM5FT2CPDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Tests pass on my machine. |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 83.51% 83.41% -0.10%
==========================================
Files 104 104
Lines 6319 6319
==========================================
- Hits 5277 5271 -6
- Misses 1042 1048 +6
Continue to review full report at Codecov.
|
test passes on julia nightly, but fails on julia 1.6, this is unrelated (happens because we have the manifest in the repo, a thing that we shouldn't). so, im gonna merge and remove the manifest myself |
Fixes