Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV.jl deprecations #46

Merged
merged 6 commits into from
Oct 8, 2021
Merged

Conversation

stillyslalom
Copy link
Contributor

Fixes

julia> model2 = PR(["water", "acetone"])
┌ Warning: `lazystrings` keyword argument is deprecated; use `stringtype=PosLenString` instead
└ @ CSV C:\Users\alexa\.julia\packages\CSV\owrEo\src\context.jl:270
┌ Warning: `lazystrings` keyword argument is deprecated; use `stringtype=PosLenString` instead
└ @ CSV C:\Users\alexa\.julia\packages\CSV\owrEo\src\context.jl:270
┌ Warning: `lazystrings` keyword argument is deprecated; use `stringtype=PosLenString` instead
└ @ CSV C:\Users\alexa\.julia\packages\CSV\owrEo\src\context.jl:270
┌ Warning: `lazystrings` keyword argument is deprecated; use `stringtype=PosLenString` instead
└ @ CSV C:\Users\alexa\.julia\packages\CSV\owrEo\src\context.jl:270
┌ Warning: `lazystrings` keyword argument is deprecated; use `stringtype=PosLenString` instead
└ @ CSV C:\Users\alexa\.julia\packages\CSV\owrEo\src\context.jl:270

@longemen3000
Copy link
Member

Nice!, can you up the package version from 0.2.2 to 0.2.3?

@longemen3000
Copy link
Member

Mmm, the errors are relevant

@stillyslalom
Copy link
Contributor Author

stillyslalom commented Oct 8, 2021 via email

@stillyslalom
Copy link
Contributor Author

Tests pass on my machine.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #46 (89d6e84) into master (1b0b910) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   83.51%   83.41%   -0.10%     
==========================================
  Files         104      104              
  Lines        6319     6319              
==========================================
- Hits         5277     5271       -6     
- Misses       1042     1048       +6     
Impacted Files Coverage Δ
src/utils/database.jl 89.39% <100.00%> (-0.37%) ⬇️
src/models/eos/Activity/COSMOSAC/utils.jl 90.90% <0.00%> (-9.10%) ⬇️
...property_solvers/multicomponent/bubble_pressure.jl 93.75% <0.00%> (-3.13%) ⬇️
src/models/combiningrules.jl 98.55% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0b910...89d6e84. Read the comment docs.

@longemen3000
Copy link
Member

test passes on julia nightly, but fails on julia 1.6, this is unrelated (happens because we have the manifest in the repo, a thing that we shouldn't). so, im gonna merge and remove the manifest myself

@longemen3000 longemen3000 merged commit 215d0b8 into ClapeyronThermo:master Oct 8, 2021
@stillyslalom stillyslalom deleted the patch-1 branch October 9, 2021 00:22
pw0908 pushed a commit that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants