Cubic (mixing) optimization #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cubic-optimization
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 83.79% 83.94% +0.14%
==========================================
Files 109 109
Lines 6875 6913 +38
==========================================
+ Hits 5761 5803 +42
+ Misses 1114 1110 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cubic rewrite gave us unseen flexibility, but we lost some speed in the progress. this pr aims to get some of that speed back.
b, that is, they use a diferent bij that the returned by lorentz-bertelot. to acomodate this, a new functionab_premixing(Type{Model},mixing,Tc,pc,k), so we can dispatch on. that function is now used by VdW, PR, and RK models