Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made PR autodiffable, like RK #64

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

TJP-Karpowski
Copy link
Contributor

Hi,
I changed the definition of k3 to be of the same type as the other parameters. This is done similarly in the RK-cubic model.

This is important for forwardDiff calls through the p,T functions like:
dHdT(model,p,T,n) = ForwardDiff.derivative(dT-> Clapeyron.enthalpy(model,p,dT,n ),T)
which are now possible for PR-models as well.

@longemen3000 longemen3000 merged commit f54f00f into ClapeyronThermo:master Jan 25, 2022
pw0908 pushed a commit that referenced this pull request Apr 28, 2022
made PR autodiffable, like  RK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants