-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find_missing_groups
function
#5
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
+ Coverage 60.00% 83.20% +23.20%
===========================================
Files 5 6 +1
Lines 245 399 +154
===========================================
+ Hits 147 332 +185
+ Misses 98 67 -31 ☔ View full report in Codecov by Sentry. |
src/missing_groups.jl
Outdated
for k in 1:max_group_size-1 | ||
combs = Combinatorics.combinations(1:nbonds, k) | ||
for comb in combs | ||
if any(bondable_atom_types[comb] .== "C" .|| bondable_atom_types[comb] .== "c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support for .||
was added in 1.7 haha
…r.jl into simple_search
…CIdentifier.jl into simple_search
Things left to do in this branch: