Use JSON for tag and feedback requests. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,5 +28,6 @@ _testmain.go | |||
| *.exe | |||
| *.test | |||
| *.prof | |||
| *.swp | |||
|
LGTM. As discussed, given that this client is new and that Go doesn't have function overloading, seems better to break the Tag() API than introduce an awkwardly named replacement. |
solongordon
force-pushed
the
solon-json-requests
branch
from
7fd4c9f
to
1898a27
Compare
added 2 commits
December 7, 2015 15:08
I switched tag and feedback requests to use JSON rather than form data. (The API supports both.) This simplifies request construction and makes it easier to add more request parameters later. This is a breaking change for the Tag function, but it should help avoid more breaking changes in the future.
This allows specifying a non-default model for a tag request.
solongordon
force-pushed
the
solon-json-requests
branch
from
1898a27
to
dd00163
Compare
solongordon
pushed a commit
that referenced
this pull request
Dec 7, 2015
Use JSON for tag and feedback requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched tag and feedback requests to use JSON rather than form data.
(The API supports both.) This simplifies request construction and makes
it easier to add more request parameters later.
This is a breaking change for the Tag function, but it should help
avoid more breaking changes in the future.