Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-396]: Dataset Version ID support #315

Merged
merged 2 commits into from Mar 19, 2024
Merged

[DEVX-396]: Dataset Version ID support #315

merged 2 commits into from Mar 19, 2024

Conversation

sanjaychelliah
Copy link
Contributor

@sanjaychelliah sanjaychelliah commented Mar 19, 2024 •
edited

Why

  • Dataset version ID support in
    • app.dataset()
    • Dataset()
  • Dataset.list_versions() improvement
  • README change for dataset.export()
  • Improved log messages for Dataset Export.

How

  • Added version_id param in Dataset class and app.dataset function
  • Removed redundant info for list_versions()

Tests

  • Existing tests cover this

sainivedh
sainivedh reviewed Mar 19, 2024
View reviewed changes
clarifai/client/app.py Outdated Show resolved Hide resolved
clarifai/datasets/export/inputs_annotations.py Outdated Show resolved Hide resolved
@sanjaychelliah sanjaychelliah mentioned this pull request Mar 19, 2024
Merged
sainivedh
sainivedh approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@sainivedh sainivedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanjaychelliah sanjaychelliah merged commit 9589d63 into master Mar 19, 2024
17 checks passed
@sanjaychelliah sanjaychelliah deleted the DEVX-396_Version_ID_support branch March 19, 2024 14:45
@sanjaychelliah sanjaychelliah mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainivedh sainivedh sainivedh approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanjaychelliah @sainivedh