fix: position change weird animation #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Manukyanq
commented
Oct 2, 2023
| // check if piece matches or if removed piece was a pawn and new square is on 1st or 8th rank (promotion) | ||
| const newSquare = ( | ||
| Object.entries(positionDifferences.added) as [Square, Pc][] | ||
| ).find( | ||
| ([s, p]) => | ||
| p === removedPiece || | ||
| (removedPiece?.[1] === "P" && (s[1] === "1" || s[1] === "8")) | ||
| p === removedPiece || onPromotionCheck(square, s, removedPiece) |
There was a problem hiding this comment.
before
before.mov
and after
Untitled.mov
Clariity
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106 fix
All changes in storybook are for test and unactual and they have to be removed before merge