Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useDrag dependency array #124

Closed
wants to merge 1 commit into from
Closed

fix: useDrag dependency array #124

wants to merge 1 commit into from

Conversation

Manukyanq
Copy link
Contributor

@Manukyanq Manukyanq commented Jan 21, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chessboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 1:26pm

@Clariity
Copy link
Owner

does this work or add any unnecessary re-renders if the provided isDraggablePiece function isn't wrapped in a useCallback?

@Manukyanq
Copy link
Contributor Author

Manukyanq commented Jan 23, 2024 •
edited
Loading

does this work or add any unnecessary re-renders if the provided isDraggablePiece function isn't wrapped in a useCallback?

Good question!🤔 Yes it will add a ton of unnecessary re-renders w/o useCallback, so IDK what to do with #123 and close this PR for a while

@Manukyanq Manukyanq closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Manukyanq @Clariity