Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Click to Move story does not reset correctly if square click… #62

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Bug fix: Click to Move story does not reset correctly if square click… #62

merged 1 commit into from
Mar 3, 2023

Conversation

richardjzhang
Copy link
Contributor

@richardjzhang richardjzhang commented Mar 3, 2023 •
edited
Loading

This PR fixes a bug in the "Click to Move" story - https://react-chessboard.com/?path=/story/example-chessboard--click-to-move

To reproduce:

  1. Click a square with a piece
  2. Click a square with no piece. You should see no changes in the options as well as the original piece selected
  3. Try to move the original piece by clicking a valid square option displayed on the board. The piece highlighted won't move
Screen.Recording.2023-03-03.at.1.01.55.pm.mov

@vercel
Copy link

vercel bot commented Mar 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-chessboard ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 2:15AM (UTC)

Clariity
Clariity approved these changes Mar 3, 2023
View reviewed changes
Copy link
Owner

@Clariity Clariity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@Clariity Clariity merged commit 74473d2 into Clariity:main Mar 3, 2023
@richardjzhang
Copy link
Contributor Author

richardjzhang commented Mar 4, 2023 •
edited
Loading

@Clariity great stuff to you sir! Thank you for this awesome library 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clariity Clariity Clariity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardjzhang @Clariity