Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Create CommandReply Broker #137

Merged
merged 5 commits into from
May 19, 2021
Merged

Conversation

vladyslav-fenchak
Copy link
Contributor

CommandReply Broker #123

CommandReply Broker #123
@vladyslav-fenchak vladyslav-fenchak added the enhancement New feature or request label May 18, 2021
@vladyslav-fenchak vladyslav-fenchak self-assigned this May 18, 2021
@vladyslav-fenchak vladyslav-fenchak added this to In progress in Minos Microservice via automation May 18, 2021
Copy link
Contributor

@garciparedes garciparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vladyslav-fenchak! I think that by mistake you ha've included docs-related files. Could you remove?

@garciparedes
Copy link
Contributor

garciparedes commented May 18, 2021

To avoid these kinds of problems, I'll create an issue to update the .gitignore and exclude these files to avoid future cases like this one. 😊

Copy link
Contributor

@garciparedes garciparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again @vladyslav-fenchak, I've already seen that you've already fixed the troubles related with the documentation.

After checking the changes I need to say that it looks good to me!

* Raise a exception if config is not properly set.
* Increase coverage.
@andrea-mucci andrea-mucci merged commit 324fba4 into 0.0.3 May 19, 2021
Minos Microservice automation moved this from In progress to Done May 19, 2021
@andrea-mucci andrea-mucci deleted the issue-123-commandreply-broker branch May 19, 2021 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Update .gitignore ignoring documentation-generated files CommandReply Broker
3 participants