Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor worker for dependency injection #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dinoboff
Copy link
Contributor

@dinoboff dinoboff commented Sep 27, 2016

  • refactor for dependency injection: expect for the helpers (like lodash.*) and request, there's no need to monkey patch imported modules.
  • get 100% coverage of src/*.js
  • implement pivotal expert service handler: I am assuming the worker can get anonymous access to pivotal expert firebase app for some public data; We just a regular client apiKey and the path to the achievement to fetch.
  • add more debug message.
  • add back code school service handler.
  • add some kind of e2e test for index.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant