Assign TotalTime/LastLogin earlier in login process to avoid a small …

…window where a player in Onelist list has nonsensical TotalTime/LastLogin values (Thanks Spicycombo)
ClassiCube · Mar 19, 2023 · 8dde70e · 8dde70e
1 parent 18afc1f
commit 8dde70e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/MCGalaxy/Player/Player.Login.cs b/MCGalaxy/Player/Player.Login.cs
@@ -62,6 +62,10 @@ public partial class Player : IDisposable
             OnPlayerFinishConnectingEvent.Call(this);
             if (cancelconnecting) { cancelconnecting = false; return; }
 
+            SessionStartTime = DateTime.UtcNow;
+            LastLogin = DateTime.Now;
+            TotalTime = TimeSpan.FromSeconds(1);
+
             lock (PlayerInfo.Online.locker) {
                 // Check if any players online have same name
                 clone = FindClone(truename);
@@ -87,9 +91,6 @@ public partial class Player : IDisposable
             if (Socket.Disconnected) return;
             loggedIn = true;
 
-            SessionStartTime = DateTime.UtcNow;
-            LastLogin = DateTime.Now;
-            TotalTime = TimeSpan.FromSeconds(1);
             GetPlayerStats();
             ShowWelcome();
             CheckState();