Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twemoji grunt task is broken #136

Closed
Mte90 opened this issue Jul 11, 2019 · 0 comments · Fixed by ClassicPress/ClassicPress#446
Closed

Twemoji grunt task is broken #136

Mte90 opened this issue Jul 11, 2019 · 0 comments · Fixed by ClassicPress/ClassicPress#446
Assignees
@Mte90

Comments

@Mte90
Copy link
Contributor

Mte90 commented Jul 11, 2019

Looking at https://travis-ci.org/ClassicPress/ClassicPress/jobs/556749640
All the travis tests are broken,
It is using a url to download the twemoji that is wrong https://github.com/ClassicPress/ClassicPress/blob/develop/Gruntfile.js#L732

The same issue there is in wordpress https://github.com/WordPress/wordpress-develop/blob/master/Gruntfile.js#L1024

The new url is 'https://github.com/twitter/twemoji.git/branches/gh-pages/2/svg' I am testing it anyway before to do the pr.
@Mte90 Mte90 self-assigned this Jul 11, 2019
@Mte90 Mte90 mentioned this issue Jul 11, 2019
Merged
3 tasks
@nylen nylen mentioned this issue Nov 20, 2023
Closed
nylen referenced this issue in ClassicPress/ClassicPress Jul 14, 2019
@Mte90 @nylen
Fix twemoji file list (#446)
6149791 
Fixes #445.
@viktorix viktorix transferred this issue from ClassicPress/ClassicPress Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mte90 Mte90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #445 - Update tweemoji url in gruntfile
1 participant
@Mte90