Backport WordPress reset password form changes

[viktorix]

I noticed password reset forms have changed in WP, making them more accessible. We should incorporate these changes. Two examples:

After requesting password reset, they hide the form and show a message:

https://core.trac.wordpress.org/ticket/40605
https://core.trac.wordpress.org/changeset/48303
https://core.trac.wordpress.org/changeset/48304
https://core.trac.wordpress.org/changeset/48305

Once you're on the password reset page:

https://core.trac.wordpress.org/ticket/39638
https://core.trac.wordpress.org/changeset/50153

In addition to form changes, they also changed show password button. It's a right now in CP, needs to be backported so it's a proper button. This, I believe, is here:
https://core.trac.wordpress.org/ticket/42888
https://core.trac.wordpress.org/changeset/46256

I'll look into backporting these.

[ClassyBot]

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/center-lost-password-back-links-on-login-page/3613/49

[mattyrob]

Some history in the 'show password' button is here:
ClassicPress/ClassicPress#525

[viktorix]

Thanks @mattyrob. Interesting discussion. I see admin styles were brought up. I started a discussion about backporting high contrast UI changes, which might be relevant.

My main concern with the changes in these changesets are accessibility. If we don't want to backport styling changes, I can look into adding functionality myself. Backporting is just one way of getting this done.

I started looking into this when I noticed show password button on the password reset page was a span without tabindex, so not accessible at all.

[nylen]

All changesets mentioned here look like they should be relatively straightforward to backport, except for https://core.trac.wordpress.org/changeset/46256. For that one see my previous comment at ClassicPress/ClassicPress#525 (comment):

Backporting any change that intersects with WP's refactoring of admin styles is especially complicated (see above for some changesets that still need to be included, and there may be more since then).

I'd recommend starting with the other changesets first in a dedicated PR, but probably best to do that after we've completed the redesign of the login page (#796).

[nylen]

Also, I still think it's generally better to use the backport script and then adapt a change to ClassicPress as much as needed, even if this means almost redoing it. This way we keep a clear record of which WP changes we have actually adopted.

[viktorix]

This one is mine, it will be included in v2.0. Closing ticket.