Add relationships between (a) posts and attachments and (b) posts and featured images #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st and any attachment it uses
KTS915
changed the title
|
Latest commit splits featured images off into their own column, which I think makes things both clearer and cleaner than before. The one thing I'm not sure of now is whether the date should be appended to the post name. I think it would look nicer without the date, but maybe that's useful information for some users. What do others think? |
|
I'm for leaving without the date. |
xxsimoxx
approved these changes
Jul 1, 2024
|
I've pushed a commit to bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no sensible way to find which media files are being used on which posts or pages (and which are not being used at all). This problem was even the subject of an article in WP Tavern: https://wptavern.com/the-problem-with-image-attachments-in-wordpress
After that article, a plugin was created to address the problem: see https://wordpress.org/plugins/find-posts-using-attachment/
That plugin has had mixed reviews, and it works by relying on querying post meta to find posts. That's a notoriously slow and problematic query, and it won't scale.
This PR presents its results in a manner inspired by that plugin, as seen below:
But this PR generates those results in a very different way from that plugin. Rather than rely on querying metadata, it uses the object relationships table that is the subject of PR #1429. For this reason, that PR must be merged before this one.
But this PR has wider implications because it provides an easy way not only to find either a featured image or an attachment (a media file used in the post's content) from a post but also to find a post from either a featured image or an attachment. Note: "post" here includes pages and all custom post types.
Once PR #1429 and this PR are merged, relationships between new posts and their associated featured image or attachments will automatically be kept up to date. Older posts and their associates will be brought up to date when re-saved.
Closes #1435.