Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trac ticket integration from unit tests #43

Merged
merged 3 commits into from Sep 10, 2018

Conversation

nylen
Copy link
Contributor

@nylen nylen commented Sep 8, 2018

There is functionality in the WP unit tests that is disabled by default, but can call out to https://core.trac.wordpress.org/ to determine whether a given test should be run.

We can remove all of this, and convert the corresponding @ticket 12345 annotations to @see references, for a couple of different reasons:

  • We won't be using Trac in this project.
  • Unit tests should be self-contained without relying on external state or a potentially flaky or unavailable network connection.

@nylen nylen force-pushed the remove/tests-trac-integration branch from 54ad056 to f603fdf Compare September 8, 2018 02:59
@nylen nylen merged commit c30eeb1 into master Sep 10, 2018
@nylen nylen deleted the remove/tests-trac-integration branch September 10, 2018 19:34
mattyrob added a commit that referenced this pull request Nov 20, 2023
Renovate[bot]: Update dependency rollup to v3.21.5

Merge pull request #43 from ClassicPress/renovate/rollup-3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant