Fix get comment 8 0 #714
Merged
Fix get comment 8 0 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reference, value given" error in `WP_Comment_Query::get_comments()`. The WP native `get_comment()` function expects the first argument `$comment` to be passed by reference. The PHP `array_map()` function, however, passes by value, not by reference, resulting in an "arguments must be passed by reference, value given" error. The PHP native `array_walk()` function does pass by reference. Using this prevents the error on PHP 8 and maintains the existing behaviour on PHP < 8. WP:Props jrf. See https://core.trac.wordpress.org/ticket/50913. Conflicts: - src/wp-includes/class-wp-comment-query.php --- Merges https://core.trac.wordpress.org/changeset/48838 / WordPress/wordpress-develop@29bfc56ca2 to ClassicPress.
… `get_comment()` definition. This fixes a PHP 8 "argument must be passed by reference, value given" error when using `array_map( 'get_comment', ... )`. Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around. Note: This reverts https://core.trac.wordpress.org/changeset/48838, which is now redundant. Follow-up to a similar change for `get_post()` in https://core.trac.wordpress.org/changeset/21572. See https://core.trac.wordpress.org/ticket/50913. --- Merges https://core.trac.wordpress.org/changeset/48961 / WordPress/wordpress-develop@875acd7b37 to ClassicPress.
bahiirwa
added
scope: php8
bahiirwa
added
the
type: wp backport
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/work-towards-release-1-4-0/3305/1 |
mattyrob
approved these changes
Sep 14, 2021
nylen
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
There is a small problem with this PR: the commit marked "Fix Merge Conflicts for 48838" actually reverts r48838 instead of fixing the conflicts with it.
However, the next change (backporting r48961) would undo r48838 anyway, so the PR ends up with the correct result when all changes are taken into account.
Therefore this PR is good to ship.
|
Reviewed during Slack meeting and agreed for commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr fixes the PHP 8.0 compatibility issues and closes ClassicPress/ClassicPress-v1#80 (Issue is detailed)
PR constains Merge conflicts and Backport changesets
as #comment:2 suggests.
How is tested?
After the patch, my admin area has not issue as in screenshot.
Yet pre-patch, we had
