Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new section in payments tab not working #332

Merged
merged 1 commit into from Sep 1, 2021
Merged

Fix new section in payments tab not working #332

merged 1 commit into from Sep 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2021

All Submissions:

Changes proposed in this Pull Request:

Change the logic in the class-wc-settings-payment-gateways.php file so that new sections created under the Payments tab will work correctly. This was an existing bug in WC 3.5.3 that was later fixed with this PR: woocommerce/woocommerce#22988

How to test the changes in this Pull Request:

  1. Copy the revised class-wc-settings-payment-gateways.php file to a test installation
  2. Create a new section following this tutorial: https://docs.woocommerce.com/document/adding-a-section-to-a-settings-tab/
  • make sure you use the woocommerce_get_sections_checkout filter.
  1. Visit the Payments tab in the setting and ensure that the new section is showing and the screen displays correctly when clicked.

Screenshot - before:

payments0

Screenshot - after:

payments2

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you included screenshots before/after your changes, if applicable?

Discussion on forum is here: https://forums.classicpress.net/t/classiccommerce-not-triggering-filter-for-adding-settings-sections-in-tabs/3508

Thanks to arnandegans for bringing it to our attention.

@ClassyBot
Copy link

This pull request has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/classiccommerce-not-triggering-filter-for-adding-settings-sections-in-tabs/3508/15

@bahiirwa
Copy link
Collaborator

bahiirwa commented Sep 1, 2021

Thanks for raising this @simplycomputing. The solution made is solid.

Adding these for the sake of the history:
woocommerce/woocommerce@2abf39c woocommerce/woocommerce@0211757

@striebwj striebwj merged commit a97e3f9 into ClassicPress:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants