Adds Beaver Builder support. #33
Conversation
| @@ -0,0 +1,20 @@ | |||
| (function($){ | |||
There was a problem hiding this comment.
Indentation is a bit off in this file, which makes it harder to read. It looks like most other JS files in this project use tabs.
| ClassicSEOIntegration.prototype.hooks = function() { | ||
| classicSEOApp.registerPlugin( 'bb-seo' ) | ||
| wp.hooks.addFilter( 'cpseo_content', 'bb-seo', function(content) { | ||
| return window.classicSEO.beaverbuilder.pagedata; |
There was a problem hiding this comment.
It looks like window.classicSEO.beaverbuilder will be undefined if Beaver Builder is not loaded. Maybe this is not actually a problem though, since the script will only be registered if BB is loaded...
There was a problem hiding this comment.
Yes, the script won't load if BB is not installed and active.
| */ | ||
| private function content_data() { | ||
|
|
||
| $id = $_GET['post']; |
There was a problem hiding this comment.
This looks like it needs a permission / nonce check.
There was a problem hiding this comment.
For when this is revisited: using get_the_ID() might be a better option here?
There was a problem hiding this comment.
get_the_ID() is a wp loop function. This is all happening in wp admin on a post/page edit screen.
|
Thanks James. I've carried out much testing on this code and as I've said to @Pross , I'm struggling to see what difference it makes to Classic SEO. Without this code, Classic SEO does recognise a lot of the Beaver Builder content but, for example, it doesn't read alt tags on images, even with this code. I'm planning to revisit this shortly as I'd like to get it into beta 2 but I've asked @Pross to take another look. I may leave this until after v1 has been released. |
Fixes #32