New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameOverhead item text changes #1591

Merged

andreakarasho merged 2 commits into ClassicUO:main from roxya:nameoverhead-itemtext

Feb 15, 2023

Collaborator

roxya commented Feb 15, 2023

The OPL tends to have the quantity already so it's redundant when using tooltips.
Evaluate plural strings in itemdata names like Diamond%s%

I don't know if it's worth using ValueStringBuilder instead of += concatenation here.

roxya added 2 commits

February 15, 2023 14:36


          NameOverhead amount: before item name, and only show if no OPL

73fafc1


          NameOverhead evaluate plural strings for items

87b8e58

Collaborator

andreakarasho commented Feb 15, 2023

Concatenation is fine here, thank you for the PR!

andreakarasho approved these changes

View reviewed changes

andreakarasho merged commit b5f0aa7 into ClassicUO:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment