Decoupling, continued #1598
Merged
Decoupling, continued #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I recently added https://github.com/ClassicUO/ClassicUO/blob/main/Directory.Build.props#L3-L14 file to replace commons properties between csproj. So you don't need anymore to specify some of these props
|
Updated to use Directory.Build.props |
added 4 commits
February 28, 2023 10:05
Remove a lot of unused configurations
This seems to be an old version of the font renderer that isn't used anymore.
Likely all of the Draw() calls should move over in some form too, but for now keep the code as similar as possible.
IO is for reading from disk. Assets is for managing in-memory assets. The lines between these libraries are not at all right, but this was the simplest way to separate the files for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of these libraries have the correct boundaries/APIs. Instead, this is split in the way that was the absolute smallest code change. I'll do another pull request with refactoring to get the boundaries/APIs/responsibilities right later on.