The order in which items are shown in grid-loot will now depend on item type or its parameters. #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type or its parameters. Motivation: some items are likely to be always looted (e.g. gold, gems) and when looting is performed automatically (e.g. by Razor macros) it makes other items to move in a grid making it harder to browse their properties. Hence, items like gold should be at the end of the grid.
|
Please let me know in case if I need to raise an issue ticket first, in order to agree upon the feature implemented in PR. |
|
|
||
| y += gridItem.Height + 20; | ||
| if (it.IsLootable) |
There was a problem hiding this comment.
probably better to invert the if statement and continue [readability stuff]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: some items are likely to be always looted (e.g. gold, gems) and when looting is performed (usually automatically e.g. by Razor macros, but also manually by other players) it makes other items to move in a grid making it harder to browse their properties. Hence, items like gold should be at the end of the grid. Stackable items have no custom properties, so displaying them at the bottom of the grid is beneficial for players: it is more convenient to browse the loot and allows saving the time.