Race change gump implementation #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the Gargoyle? Should they be supported? |
|
Gargoyle is supported 👍
…On Wed, Oct 25, 2023, 2:56 PM andreakarasho ***@***.***> wrote:
What about the Gargoyle? Should they be supported?
—
Reply to this email directly, view it on GitHub
<#1639 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5OHQJKYFKSTBHXOW4NFL3YBF4JRAVCNFSM6AAAAAA6OOCSM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGA2DEMJRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
LGTM |
andreakarasho
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took and modified a lot of the code from the CreateCharAppearanceGump but because we are in-game by the time anyone receives this gump there had to be a lot of changes.
This was mainly due to fake player/items(hair and beard) being cleaned up automatically, likely due to not being in-game anywhere.
I tested this with a ServUO server and all is working as intended.
This would resolve #1002
This implementation in game:
The gump in the original client can be seen in #1002
Let me know what needs changed, lets get this implemented!