Fix Server Ping in Server List #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The System.Net.NetworkInformation.Ping class requires the IP address in little-endian format. Previously, it was passed in big-endian format (IP address in reverse order. 1.2.3.4 became 4.3.2.1). As a result, the servers were never pinged correctly. To save the IP address in the correct order in _ipAddress, the byte order must be reversed so that the least significant byte (LSB) comes first.
andreakarasho
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System.Net.NetworkInformation.Ping class requires the IP address in little-endian format. Previously, it was passed in big-endian format (IP address in reverse order. 1.2.3.4 became 4.3.2.1). As a result, the servers were never pinged correctly. To save the IP address in the correct order in _ipAddress, the byte order must be reversed so that the least significant byte (LSB) comes first.