Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

Several Classes in one styleClassId? GONE or Planned? #67

Closed
denislutz opened this issue Jul 31, 2014 · 5 comments · Fixed by #68
Closed

Several Classes in one styleClassId? GONE or Planned? #67

denislutz opened this issue Jul 31, 2014 · 5 comments · Fixed by #68

Comments

@denislutz
Copy link

Hey Guys,

first of all , thanks for you work, I love classy.

I worked from the latest git branch directly and was able to set several classes on one styleClassId like:

self.userName = [[MYTextField alloc] initWithStyleClassId:@"primaryTextfield userName"

Where the firstclass is rather global style and userName a chance to set things specifically to this element.

With a new update today it seems like this feature is gone again.

Can you give me a hint what to do?
If this is not possible anymore can you at least give the revision number from which I could fork and work for now with this feature still working?

Thanks in advance?

@denislutz
Copy link
Author

Hey Jonas,

It seems that something in the commit bced8d8 is disabling this feature.

To get it running I am pointing right now to the last commit that has it which is 00c0509 .

I hope we can get it back in since this is a very powerful feature, I would be too bad not to have it.

Thx.

@cloudkite
Copy link
Contributor

@denislutz thanks for reporting!

@keithnorm If you get a chance can you take a look into this? sounds like its no longer applying multiple style classes to views possibly due to the lookup table optimisation

@denislutz
Copy link
Author

No problem. Happy that you plan to keep this feature.

@keithnorm
Copy link
Contributor

Yep I'll get a fix for that tonight hopefully. Sorry about that!

@denislutz
Copy link
Author

Nice, thx bro!

keithnorm added a commit to keithnorm/Classy that referenced this issue Aug 1, 2014
…en finding possible style nodes from the lookup table
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants