This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
Fixed Swift class resolution when app name has spaces #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aggouri interesting, thanks for the PR! And sorry for the late reply :) Do you have a reference link for this, or you researched this on your own? I am wondering if it is only the case with spaces, or would also happen with some other special characters? |
|
Hi, sorry I don't have a reference link. My app has a space in the name, so I found out the hard way. I'm afraid I don't remember where I found the info, but I guess it could happen with other characters :-( |
|
@Aggouri that's fine, thanks |
mikeger
added a commit
that referenced
this pull request
Dec 22, 2015
Fixed Swift class resolution when app name has spaces
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift class name resolution does not work when the App Name has spaces in it. The parser fails to find Swift classes and reports an error.
This pull request fixes the issue by replacing all occurrences of " " (space) in the App Name with "_" (underscore), when resolving the Swift class name.