Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

View controller styling #52

Closed
wants to merge 1 commit into from
Closed

View controller styling #52

wants to merge 1 commit into from

Conversation

dzindra
Copy link
Contributor

@dzindra dzindra commented Mar 19, 2014

View controller styling can be usefull for example when you want to set icon images to your custom view controller.

I noticed that it is not working properly - setter methods were not called at all. I first suspected wrong keys in cas_updateStyling and cas_setNeedsUpdateStyling. However additional call to cas_setNeedsUpdateStyling was required in setView method. Now it works in my case but I'm not sure if I haven't missed something.

…ntroller additions and scheduled view controller for styling in setView method.
@cloudkite
Copy link
Contributor

@dzindra thanks, theres a big overhaul coming to this cas_needsUpdateStyling etc methods as they are a bit fragile. So don't want to merge this at this stage as its all likely to change soon.

@dzindra
Copy link
Contributor Author

dzindra commented Mar 21, 2014

Ok, I understand. How long till the big overhaul? I quite need the ability to style view controllers which is fixed by this PR (line 28 ). Should I make another pull request with this line or just use my repo with modified podfile?

@cloudkite
Copy link
Contributor

Maybe point to your podfile for now, hopefully have something next week sometime. Thanks

@cloudkite cloudkite closed this Mar 23, 2014
@cloudkite
Copy link
Contributor

Just did a refactor and included your change 6f0c2a4 let me know if its still working for you.

@dzindra
Copy link
Contributor Author

dzindra commented Mar 27, 2014

Yes, it works perfectly thank you. For future readers: view controller properties are styled after a call to viewDidLoad!

Btw keys for associated object in UIViewController+CASAdditions.m methods cas_updateStyling, cas_needsUpdateStyling and cas_setNeedsUpdateStyling are still inconsistent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants