This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
fixes #56 sort style nodes in ascending precedence order before applying rules. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore applying rules.
This is to be more in line with CSS rules such that given this scenario:
UILabel {
text-color: blue;
}
UILabel {
text-color: red;
}
A UILabel should have red text.
| @@ -57,8 +57,21 @@ - (void)styleItem:(id<CASStyleableItem>)item { | |||
| // load default style file | |||
| self.filePath = [[NSBundle mainBundle] pathForResource:@"stylesheet.cas" ofType:nil]; | |||
| } | |||
|
|
|||
| // order ascending by precedence | |||
| [self.styleNodes sortWithOptions:NSSortStable usingComparator:^NSComparisonResult(CASStyleNode *n1, CASStyleNode *n2) { | |||
There was a problem hiding this comment.
not sure why ordering needs to be done again here? Its already being ordered on line 148? This would be very costly as it means ordering would happen every time a view is styled?
There was a problem hiding this comment.
Yeah you're right that is unnecessary. Since self.styleNodes is only set in setFilePath:error and it gets sorted in that method. I removed the sorting from styleItem and the tests still pass.
…already by setFilePath:error
|
Cool thanks for the contribution! |
cloudkite
added a commit
that referenced
this pull request
Apr 29, 2014
fixes #56 sort style nodes in ascending precedence order before applying rules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be more in line with CSS rules such that given this scenario:
UILabel {
text-color: blue;
}
UILabel {
text-color: red;
}
A UILabel should have red text.
Also, this missing Ball.png was breaking the example app. It's not used but I added it anyway as a quick fix.
NOTE: This is a fundamental change to Classy's behavior and may cause some stylesheets to appear to be broken if they were written in a way that relies on applying the rules from the bottom to the top of a stylesheet.