Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/specs for views and fix problems #8

Merged
merged 29 commits into from
Oct 3, 2023

Conversation

ClaudiaRojasSoto
Copy link
Owner

Description

This PR integrates comprehensive Capybara specs for all user-facing views, thereby meeting all the user stories outlined in the project requirements. Additionally, it addresses performance issues related to N+1 queries in post and comment fetching.

Key Changes

  • Linting: All files have been linted, and there are zero linting errors.
  • Gitflow: This feature branch follows the correct Gitflow practices.
  • N+1 Query Issue: Resolved N+1 query problems in post and comment fetching without using the bullet gem.
  • Integration Tests:
    • Wrote Capybara specs for the User Index Page, User Show Page, User Post Index Page, and Post Show Page.
    • Covered all user stories and edge cases, ensuring robustness and user-friendly design.

Testing

  • All RSpec and Capybara tests pass.
  • Manual testing was performed to verify that the UI and UX behaved as expected.

How to Test this PR

  • Checkout to this branch.
  • Run bundle install.
  • Run rails db:migrate.
  • Run rspec.

Screenshots

  • Before resolved n+1 query problems

Captura de pantalla 2023-09-28 a la(s) 15 35 26

  • After resolving n+1 query problems

Captura de pantalla 2023-09-28 a la(s) 15 47 42

Additional Notes

  • Before resolving n+1 query problems the documentation has been updated to reflect these changes.

Please review and let me know if any changes are required.
Greetings,
@ClaudiaRojasSoto
@Dachrono

ClaudiaRojasSoto and others added 29 commits October 2, 2023 14:29
…ex and show with all the test necesaries to be sure that all the functionalities are working as expected using capybara methods with rspec
Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClaudiaRojasSoto and @Dachrono, 👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Followed Gitflow 💯
  • Descriptive PR⭐
  • Kudos for working on the Tests for the views🤩
  • No Linters error ✅
  • N+1 solved well ✅
  • All test are passed🙏🏻🔥

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit 0052d37 into develop Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants