-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/specs for views and fix problems #8
Feature/specs for views and fix problems #8
Conversation
…ex and show with all the test necesaries to be sure that all the functionalities are working as expected using capybara methods with rspec
… long methods ruls from rubocop
… long methods ruls from rubocop
… differents files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ClaudiaRojasSoto and @Dachrono, 👋🏻👋🏻
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Followed Gitflow 💯
- Descriptive PR⭐
- Kudos for working on the Tests for the views🤩
- No Linters error ✅
- N+1 solved well ✅
- All test are passed🙏🏻🔥
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
This PR integrates comprehensive Capybara specs for all user-facing views, thereby meeting all the user stories outlined in the project requirements. Additionally, it addresses performance issues related to N+1 queries in post and comment fetching.
Key Changes
Testing
How to Test this PR
Screenshots
Additional Notes
Please review and let me know if any changes are required.
Greetings,
@ClaudiaRojasSoto
@Dachrono