Feature/add devise #9
Conversation
tml of passwords
There was a problem hiding this comment.
Hi @ClaudiaRojasSoto & @Dachrono ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights ✔️
- Devise gem is used for authentication ✅
- Git flow is used correctly ✅
- Pull request has a descriptive title and summary ✅
- Repository has a professional readme file ✅
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -0,0 +1,40 @@ | |||
| <h2 class="index-title">Sign up</h2> | |||
|
|
|||
| <%= form_for(resource, as: resource_name, url: registration_path(resource_name), html: { class: 'post-form' }) do |f| %> | |||
There was a problem hiding this comment.
- [ Required ] I think it would be nice if you make the
registrationform work as expected, currently, when I fill in all the fields and click on theSign Upbutton I get the error below. Please see the screenshot below and rectify this.
Screenshot
I get this error even after filing the
namefield, kindly rectify this.
There was a problem hiding this comment.
Done!, Thank you.
| <%= form_for(resource, as: resource_name, url: session_path(resource_name), html: { class: 'post-form' }) do |f| %> | ||
| <div class="field"> | ||
| <%= f.label :email, class: 'label-fixed-width' %> <!-- Agrega la nueva clase aquí --> | ||
| <%= f.email_field :email, autofocus: true, autocomplete: "email", class: 'post-form textarea' %> | ||
| </div> | ||
|
|
||
| <div class="field"> | ||
| <%= f.label :password, class: 'label-fixed-width' %> <!-- Agrega la nueva clase aquí --> | ||
| <%= f.password_field :password, autocomplete: "current-password", class: 'post-form textarea' %> | ||
| </div> | ||
|
|
||
| <% if devise_mapping.rememberable? %> | ||
| <div class="field"> | ||
| <%= f.check_box :remember_me %> | ||
| <%= f.label :remember_me, class: 'label-fixed-width' %> <!-- Agrega la nueva clase aquí si es necesario --> | ||
| </div> | ||
| <% end %> | ||
|
|
||
| <div class="actions"> | ||
| <%= f.submit "Log in", class: 'post-form button' %> | ||
| </div> | ||
| <% end %> |
There was a problem hiding this comment.
-
[ Required ] I think it would be nice if the design for your login form is consistent with the wireframe provided for this milestone. Currently, your design varies from the wireframe in the following ways.
- In the wireframe, the
username,password, andloginbuttons have the same width while in your design the fields have varied lengths. - The
usernameandpasswordfields in the wireframe have placeholder text while theinputfields in your design don't have placeholder texts.
- In the wireframe, the
Your design
Project Wireframe
There was a problem hiding this comment.
Done!, Thank you.
| @@ -0,0 +1,40 @@ | |||
| <h2 class="index-title">Sign up</h2> | |||
|
|
|||
| <%= form_for(resource, as: resource_name, url: registration_path(resource_name), html: { class: 'post-form' }) do |f| %> | |||
There was a problem hiding this comment.
-
[ Required ] I think it would be nice if your design for the
registrationform is similar to the one provided for theSign Inform in the project wireframe. Currently, your design varies from the wireframe in the following ways.- In the wireframe, the
name,email,password, andloginbuttons have the same width while in your design the fields have varied lengths. - The
inputfields in the wireframe have placeholder text while theinputfields in your design don't have placeholder text.
- In the wireframe, the
Your design
Project wireframe
…r before action to fix the issue with the name on the sign up
There was a problem hiding this comment.
Status: Approved 🟢 🟢 🟢
Good job working on the changes highlighted by the previous reviewer 👍🏽
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉
Highlights:
✅ You set up Gitflow correctly 👍🏽
✅ The Linter checks passed successfully 👍🏽
✅ Used devise correctly as expected 👍🏽
✅ Sign up and Login UI designed nicely as expected 👍🏽
✅ Good communication with the reviewer 👍🏽
✅ Good descriptive PR and commit messages 👍🏽
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Add Devise for User Authentication
Description
This pull request adds the Devise gem to the application to manage user registration and authentication. Devise provides a flexible and secure way to handle user accounts. This ensures that users can register, confirm their emails, and reset their passwords.
General Requirements
Ruby Requirements
Project Requirements
current_usermethod fromApplicationControlleras Devise provides one.How to Test
bundle installto install the Devise gem.rails db:migrateto apply the new Devise-related database migrations.Please, review the changes made on this feature and give me feedback to improve my app. Thank you in advance.
Contributors
@ClaudiaRojasSoto
@Dachrono