Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete car item #7

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Feature/delete car item #7

merged 4 commits into from
Nov 2, 2023

Conversation

ClaudiaRojasSoto
Copy link
Owner

Description:

This pull request adds the functionality to delete cars from the list. The "Delete" button appears when the user clicks on the "Delete item" link in the sidebar panel. Clicking the "Delete" button next to each car item will remove it from the main list.

Changes:

  1. Created a new Redux slice action deleteCar to handle the deletion logic.
  2. Added extraReducers to handle the pending, fulfilled, and rejected states of the deleteCar action in the Redux store.
  3. Integrated the deleteCar action into the CarCard component, which allows users to delete cars by clicking the "Delete" button.
  4. Updated unit tests and integration tests for the new functionality.

General Requirements:

  • No linter errors.
  • Followed correct Gitflow.
  • Work is well-documented.

HTML/CSS, JavaScript, and Ruby Requirements:

  • Followed the list of best practices for HTML & CSS.
  • Followed the list of best practices for JavaScript.

How to Test:

  1. Run the application.
  2. Navigate to the car list.
  3. Click on the "Delete item" link in the sidebar panel to enter delete mode.
  4. Click on the "Delete" button next to the car you wish to delete.
  5. The car should be removed from the list.

Please review this feature and give me feedback to improve our application. Thank you in advance.
Greetings,
@ClaudiaRojasSoto

@ClaudiaRojasSoto ClaudiaRojasSoto linked an issue Nov 1, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@PabloBona PabloBona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClaudiaRojasSoto
Approved ✔
Great job, Your project is complete!
There is nothing else to say other than... it's time to merge it

Congrats! 🎉

Highlights✨
Nice Logic !
Descriptive PR⭐

@PabloBona PabloBona merged commit 4761b5a into develop Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Delete item
2 participants