Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Morning #9

Open
PabloBona opened this issue Jun 30, 2023 · 0 comments
Open

Code Review Morning #9

PabloBona opened this issue Jun 30, 2023 · 0 comments

Comments

@PabloBona
Copy link

PabloBona commented Jun 30, 2023

Code review πŸ’―

Hi @ClaudiaRojasSoto βœ‹
Your project looks amazing and works as expected. Great job! πŸ˜„

Higlights ♻️

  • The code is divided into separate modules, making it modular and maintainable.
  • The main functionality is split into multiple functions and exported appropriately.
  • The code is organized into logical sections, such as API interactions, UI interactions, and HTML/CSS.
  • The HTML structure is well-organized with appropriate class names for styling and JavaScript manipulation.
  • The background image is set dynamically using the backgroundImage variable.
  • The DOMContentLoaded event listener is used to initialize the UI interactions once the document is loaded.

We have a few suggestions so you can improve your code to the 100% 😎
I suggest you use a main tag to contain your sections of code about your content, this according to the best HTML practices.
The section tag is used to contain a specific part of code, so it could be better if you use one section for the score table and another for the form.
When you load the page, the content is not showing in the page, for a better user experience I suggest you show the scores.

Optional changes ♻️

  • Consider adding more error handling and user feedback for unsuccessful API requests.
  • Implement validation for the name and score inputs to ensure they meet the required criteria.
  • Use more descriptive variable names and add comments where necessary to improve code readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant